Page MenuHomePhabricator
Differential D12244

Allow applications to have multiple "help" menu items
ClosedPublic
Actions

Authored by epriestley on Apr 1 2015, 3:25 PM.
Tags
None
Referenced Files
F15473385: D12244.id29419.diff
Sat, Apr 5, 9:33 PM
F15466133: D12244.diff
Thu, Apr 3, 1:55 AM
F15390704: D12244.id29419.diff
Sat, Mar 15, 6:27 AM
F15387885: D12244.id29404.diff
Sat, Mar 15, 3:04 AM
F15380629: D12244.diff
Mar 14 2025, 3:55 AM
F15378101: D12244.id.diff
Mar 13 2025, 12:43 PM
Unknown Object (File)
Mar 3 2025, 6:59 PM
Unknown Object (File)
Mar 2 2025, 2:56 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7199: Expand the power of "!action" commands in email
Commits
Restricted Diffusion Commit
rPc169199e6429: Allow applications to have multiple "help" menu items
Summary

Ref T7199. Convert the single help menu item into a dropdown and allow applications to list multiple items there.

When an application has mail command objects, link them in the menu.

Test Plan

Screen_Shot_2015-04-01_at_8.24.52_AM.png (493×1 px, 78 KB)

Screen_Shot_2015-04-01_at_8.24.48_AM.png (493×1 px, 118 KB)

Diff Detail

Repository
rP Phabricator
Branch
mcom14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5081
Build 5099: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29404.Apr 1 2015, 3:25 PM
epriestley retitled this revision from to Allow applications to have multiple "help" menu items.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7199: Expand the power of "!action" commands in email.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 1 2015, 3:25 PM
btrahan accepted this revision.Apr 1 2015, 5:48 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/base/PhabricatorApplication.php
190–207

could add a link to application email (maybe that needs a better name) help doc if the application supports application emails

This revision is now accepted and ready to land.Apr 1 2015, 5:48 PM
epriestley added inline comments.Apr 1 2015, 5:49 PM
src/applications/base/PhabricatorApplication.php
190–207

I'll follow up with this.

epriestley added a comment.Apr 1 2015, 5:52 PM

Oh, D12245 adds a link to the inbound mail configuration doc.

Closed by commit rPc169199e6429: Allow applications to have multiple "help" menu items (authored by epriestley, committed by epriestley). · Explain WhyApr 1 2015, 6:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
almanac/
application/
9 lines
audit/
application/
9 lines
auth/
application/
6 lines
base/
44 lines
conduit/
application/
9 lines
differential/
application/
10 lines
diffusion/
application/
9 lines
drydock/
application/
9 lines
help/
application/
76 lines
controller/
52 lines
herald/
application/
9 lines
home/
controller/
1 line
legalpad/
application/
9 lines
maniphest/
application/
1 line
meta/
controller/
8 lines
8 lines
oauthserver/
application/
10 lines
owners/
application/
9 lines
phame/
application/
9 lines
phriction/
application/
9 lines
slowvote/
application/
9 lines

Diff 29404

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/almanac/application/PhabricatorAlmanacApplication.php

Loading...
View Options

src/applications/audit/application/PhabricatorAuditApplication.php

Loading...
View Options

src/applications/auth/application/PhabricatorAuthApplication.php

Loading...
View Options

src/applications/base/PhabricatorApplication.php

Loading...
View Options

src/applications/conduit/application/PhabricatorConduitApplication.php

Loading...
View Options

src/applications/differential/application/PhabricatorDifferentialApplication.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/drydock/application/PhabricatorDrydockApplication.php

Loading...
View Options

src/applications/help/application/PhabricatorHelpApplication.php

Loading...
View Options

src/applications/help/controller/PhabricatorHelpDocumentationController.php

Loading...
View Options

src/applications/herald/application/PhabricatorHeraldApplication.php

Loading...
View Options

src/applications/home/controller/PhabricatorHomeQuickCreateController.php

Loading...
View Options

src/applications/legalpad/application/PhabricatorLegalpadApplication.php

Loading...
View Options

src/applications/maniphest/application/PhabricatorManiphestApplication.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php

Loading...
View Options

src/applications/oauthserver/application/PhabricatorOAuthServerApplication.php

Loading...
View Options

src/applications/owners/application/PhabricatorOwnersApplication.php

Loading...
View Options

src/applications/phame/application/PhabricatorPhameApplication.php

Loading...
View Options

src/applications/phriction/application/PhabricatorPhrictionApplication.php

Loading...
View Options

src/applications/slowvote/application/PhabricatorSlowvoteApplication.php

Loading...
Phabricator · Built by Phacility