Page MenuHomePhabricator
Differential D12243

Conpherence - fix fatal if you don't have conpherences
ClosedPublic
Actions

Authored by btrahan on Apr 1 2015, 2:59 PM.
Tags
None
Referenced Files
F14845728: D12243.id29402.diff
Mon, Feb 3, 12:34 AM
Unknown Object (File)
Fri, Jan 31, 12:22 AM
Unknown Object (File)
Fri, Jan 24, 2:02 AM
Unknown Object (File)
Fri, Jan 24, 2:02 AM
Unknown Object (File)
Fri, Jan 24, 2:01 AM
Unknown Object (File)
Fri, Jan 24, 2:01 AM
Unknown Object (File)
Tue, Jan 21, 9:25 AM
Unknown Object (File)
Dec 24 2024, 7:06 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Haypence" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T7717: array_key_exists error in Conpherence thread
T7721: Unrecoverable Fatal Error when navigating to Conpherence application
Commits
Restricted Diffusion Commit
rP6f028e16e852: Conpherence - fix fatal if you don't have conpherences
Summary

Fixes T7721. Looks like this got renamed at some point but skipped. Also, change the true / false idx look ups to correct integers here since there's a warning in the error logs in this case without it.

Test Plan

made new user. loaded up conpherence and it worked. tried all the links too for good measure and they worked

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29402.Apr 1 2015, 2:59 PM
btrahan added a task: T7721: Unrecoverable Fatal Error when navigating to Conpherence application.
btrahan retitled this revision from to Conpherence - fix fatal if you don't have conpherences.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 1 2015, 2:59 PM
epriestley accepted this revision.Apr 1 2015, 2:59 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 1 2015, 2:59 PM
epriestley awarded a token.Apr 1 2015, 2:59 PM
btrahan added a task: T7717: array_key_exists error in Conpherence thread.Apr 1 2015, 2:59 PM
Closed by commit rP6f028e16e852: Conpherence - fix fatal if you don't have conpherences (authored by btrahan, committed by btrahan). · Explain WhyApr 1 2015, 3:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
view/
6 lines

Diff 29403

View Options

src/applications/conpherence/view/ConpherenceThreadListView.php

Loading...
Phabricator · Built by Phacility