Page MenuHomePhabricator
Differential D12238

Fully modularize mail commands
ClosedPublic
Actions

Authored by epriestley on Apr 1 2015, 2:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 5:04 AM
Unknown Object (File)
Fri, Dec 13, 11:57 AM
Unknown Object (File)
Thu, Dec 5, 11:08 PM
Unknown Object (File)
Wed, Nov 27, 9:14 AM
Unknown Object (File)
Nov 19 2024, 3:06 AM
Unknown Object (File)
Nov 15 2024, 11:15 AM
Unknown Object (File)
Nov 10 2024, 4:22 PM
Unknown Object (File)
Nov 7 2024, 3:15 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7199: Expand the power of "!action" commands in email
Commits
Restricted Diffusion Commit
rPc32fee0e4877: Fully modularize mail commands
Summary

Ref T7199. Everyone can have a mail command! You can have a mail command! You can have a mail command! Mail commands for everyone!

Test Plan

Used bin/mail receive-test to issue commands against files and pastes.

Diff Detail

Repository
rP Phabricator
Branch
mcom10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5075
Build 5093: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29397.Apr 1 2015, 2:39 AM
epriestley retitled this revision from to Fully modularize mail commands.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7199: Expand the power of "!action" commands in email.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 1 2015, 2:39 AM
btrahan accepted this revision.Apr 1 2015, 3:10 PM
btrahan edited edge metadata.

<3 the Oprah reference.

Inline doesn't really matter, just assumed it would work that way and give you the aliases for a specific command.

src/applications/metamta/command/MetaMTAEmailTransactionCommand.php
59

I figured the function would take a command as an input to get the aliases?

This revision is now accepted and ready to land.Apr 1 2015, 3:10 PM
Closed by commit rPc32fee0e4877: Fully modularize mail commands (authored by epriestley, committed by epriestley). · Explain WhyApr 1 2015, 3:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
files/
mail/
18 lines
metamta/
command/
81 lines
paste/
mail/
18 lines
subscriptions/
command/
33 lines
transactions/
replyhandler/
61 lines

Diff 29397

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/mail/FileReplyHandler.php

Loading...
View Options

src/applications/metamta/command/MetaMTAEmailTransactionCommand.php

Loading...
View Options

src/applications/paste/mail/PasteReplyHandler.php

Loading...
View Options

src/applications/subscriptions/command/PhabricatorSubscriptionsUnsubscribeEmailCommand.php

Loading...
View Options

src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php

Loading...
Phabricator · Built by Phacility