Page MenuHomePhabricator
Differential D12195

Fix a race condition with the chat column
ClosedPublic
Actions

Authored by epriestley on Mar 28 2015, 10:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 5:12 AM
Unknown Object (File)
Tue, Dec 10, 9:02 AM
Unknown Object (File)
Sun, Dec 8, 3:20 PM
Unknown Object (File)
Mon, Nov 25, 2:35 PM
Unknown Object (File)
Nov 12 2024, 11:04 PM
Unknown Object (File)
Nov 9 2024, 3:27 AM
Unknown Object (File)
Nov 2 2024, 7:55 AM
Unknown Object (File)
Oct 8 2024, 8:56 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T7062: JX.Device should calculate display width based on frame width (i.e., subtract chat column) not total browser width
Commits
Restricted Diffusion Commit
rPa48b486344f6: Fix a race condition with the chat column
Summary

Ref T7062. When we load a thread, we always show the column, even if it has been closed between the time we sent the request and when we're processing the response.

Normally this isn't a big deal, but it can specifically show up on mobile.

(This load also shouldn't be happening at all, but I'll fix that separately.)

Test Plan

Mobile no longer shows the column after it loads.

Diff Detail

Repository
rP Phabricator
Branch
quick6
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5025
Build 5043: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29310.Mar 28 2015, 10:20 PM
epriestley retitled this revision from to Fix a race condition with the chat column.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T7062: JX.Device should calculate display width based on frame width (i.e., subtract chat column) not total browser width.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 28 2015, 10:20 PM
chad accepted this revision.Mar 28 2015, 10:21 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 28 2015, 10:21 PM
chad added a comment.Mar 28 2015, 10:21 PM

Closed by commit rPa48b486344f6: Fix a race condition with the chat column (authored by epriestley, committed by epriestley). · Explain WhyMar 28 2015, 10:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
webroot/
rsrc/
js/
application/
conpherence/
6 lines

Diff 29310

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-durable-column.js

Loading...
Phabricator · Built by Phacility