Paths

Table of Contentst

Fix an issue with returning to a the initial page in Quicksand
ClosedPublic
Actions

Authored by epriestley on Mar 28 2015, 2:29 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7058: Quicksand gets confused if you manually navigate to the original page

Commits

Restricted Diffusion Commit
rPad1bed136c91: Fix an issue with returning to a the initial page in Quicksand

Summary

Fixes T7058. We weren't propagating state properly so some other code ended up doing the wrong thing.

Test Plan

Clicked from Home -> Anything -> Home under Quicksand, saw reloads with no double requests.
Used "back", saw back button work properly.

Diff Detail

Repository

rP Phabricator

Branch

quick3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5019
Build 5037: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29300.Mar 28 2015, 2:29 PM

epriestley retitled this revision from to Fix an issue with returning to a the initial page in Quicksand.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T7058: Quicksand gets confused if you manually navigate to the original page.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 28 2015, 2:29 PM

chad accepted this revision.Mar 28 2015, 2:35 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 28 2015, 2:35 PM

Closed by commit rPad1bed136c91: Fix an issue with returning to a the initial page in Quicksand (authored by epriestley, committed by epriestley). · Explain WhyMar 28 2015, 2:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

18 lines

webroot/

rsrc/

externals/

javelin/

lib/

History.js

2 lines

Diff 29300

View Options

resources/celerity/map.php