Add some spacing around jx-tooltips
ClosedPublic
Actions

Authored by chad on Mar 27 2015, 4:56 PM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rP90ccd37a8c47: Add some spacing around jx-tooltips

Summary

Using tooltips with icons is problematic because we currently draw the arrow after the tooltip location, meaning it goes 5px into the container. This gives a 5px padding around the outer container to better account for this.

Test Plan

tested tooltips in remarkup bar, project icon nav, and in durable column.

Diff Detail

Repository

rP Phabricator

Branch

aphront-tips

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5008
Build 5026: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29282.Mar 27 2015, 4:56 PM

chad retitled this revision from to Add some spacing around jx-tooltips.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 27 2015, 4:56 PM

epriestley accepted this revision.Mar 27 2015, 5:37 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 27 2015, 5:37 PM

Closed by commit rP90ccd37a8c47: Add some spacing around jx-tooltips (authored by chad, committed by chad). · Explain WhyMar 27 2015, 5:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

aphront/

tooltip.css

1 line

Diff 29282

View Options

resources/celerity/map.php