Calendar - error better with invalid time values
ClosedPublic
Actions

Authored by btrahan on Mar 26 2015, 7:50 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T7665: Unhandled Exception ("AphrontQueryException") - #1048: Column 'dateFrom' cannot be null

Commits

Restricted Diffusion Commit
rP871c06ab4ee4: Calendar - error better with invalid time values

Summary

Fixes T7665. Unfortunately when the user messes this up its not easy to partially recover so we just reset that time to the default.

Test Plan

set time to "00:00 AM" and got a sensible error.

Diff Detail

Repository

rP Phabricator

Branch

T7665

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4995
Build 5013: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 29258.Mar 26 2015, 7:50 PM

btrahan added a task: T7665: Unhandled Exception ("AphrontQueryException") - #1048: Column 'dateFrom' cannot be null.

btrahan retitled this revision from to Calendar - error better with invalid time values.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 26 2015, 7:50 PM

epriestley accepted this revision.Mar 26 2015, 8:02 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 26 2015, 8:02 PM

Closed by commit rP871c06ab4ee4: Calendar - error better with invalid time values (authored by btrahan, committed by btrahan). · Explain WhyMar 26 2015, 8:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

controller/

PhabricatorCalendarEventEditController.php

28 lines

Diff 29258

View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Calendar - error better with invalid time valuesClosedPublicActions