Page MenuHomePhabricator

Censor response bodies from Mercurial error messages
ClosedPublic

Authored by epriestley on Mar 26 2015, 4:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 1:16 PM
Unknown Object (File)
Sat, Jan 25, 1:16 PM
Unknown Object (File)
Sat, Jan 25, 1:16 PM
Unknown Object (File)
Fri, Jan 24, 1:46 AM
Unknown Object (File)
Fri, Jan 24, 1:46 AM
Unknown Object (File)
Fri, Jan 24, 1:46 AM
Unknown Object (File)
Thu, Jan 23, 8:27 PM
Unknown Object (File)
Tue, Jan 21, 7:03 PM
Subscribers

Details

Summary

Ref T6755. In Git and Subversion, running git clone http://google.com/ or svn checkout http://google.com/ does not echo the response body.

In Mercurial, it does. Censor it from the output of hg pull and hg clone. This prevents an attacker from:

  • Creating a Mercurial remote repository with URI http://10.0.0.1/secrets/; and
  • reading the secrets out of the error message after the clone fails.
Test Plan

Set a Mercurial remote URI to a non-Mercurial repository, ran repository update, saw censored error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable