Differential D12167

Move abandoned revisions to "needs review" when updated
ClosedPublic
Actions

Authored by epriestley on Mar 26 2015, 12:11 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7602: Updating an abandoned diff should reclaim the revision

Commits

Restricted Diffusion Commit
rPcce6d06fa5ec: Move abandoned revisions to "needs review" when updated

Summary

Fixes T7602. This is similar to the existing behavior for "changes planned" and "needs revision" revisions.

Also fix the "Update Diff" workflow so it correctly selects closed revisions as attachable.

Test Plan

Updated an abandoned revision, saw it change to "Needs Review".

Diff Detail

Repository

rP Phabricator

Branch

updateab

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4986
Build 5004: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29241.Mar 26 2015, 12:11 PM

epriestley retitled this revision from to Move abandoned revisions to "needs review" when updated.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7602: Updating an abandoned diff should reclaim the revision.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 26 2015, 12:11 PM

btrahan accepted this revision.Mar 26 2015, 6:07 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 26 2015, 6:07 PM

Closed by commit rPcce6d06fa5ec: Move abandoned revisions to "needs review" when updated (authored by epriestley, committed by epriestley). · Explain WhyMar 26 2015, 6:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialDiffViewController.php

54 lines

editor/

DifferentialTransactionEditor.php

13 lines

Diff 29241

View Options

src/applications/differential/controller/DifferentialDiffViewController.php