Page MenuHomePhabricator
Differential D12160

Mostly provide CSS for "done" states
ClosedPublic
Actions

Authored by epriestley on Mar 25 2015, 5:51 PM.
Tags
None
Referenced Files
F15526506: D12160.id29230.diff
Mon, Apr 21, 9:10 PM
F15523739: D12160.id29229.diff
Mon, Apr 21, 3:22 AM
F15483293: D12160.diff
Wed, Apr 9, 11:31 AM
F15469970: D12160.diff
Fri, Apr 4, 6:41 PM
F15462840: D12160.id29230.diff
Tue, Apr 1, 6:00 PM
F15459912: D12160.id29230.diff
Mon, Mar 31, 6:09 PM
F15454815: D12160.id29229.diff
Sat, Mar 29, 8:33 PM
F15451801: D12160.diff
Fri, Mar 28, 11:53 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T7660: Clicking "Done" should set a CSS class on the inline-comment-box
Commits
Restricted Diffusion Commit
rP1fd163d0976c: Mostly provide CSS for "done" states
Summary

Ref T7660. I'm not toggling "inline-state-is-draft" correctly in JS yet since it's a little tricky (you can reload to see it) but the main state should work.

Test Plan
  • Clicked "done", saw comment opacity fade with placeholder style.

Diff Detail

Repository
rP Phabricator
Branch
inlinecss
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4978
Build 4996: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29229.Mar 25 2015, 5:51 PM
epriestley retitled this revision from to Mostly provide CSS for "done" states.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7660: Clicking "Done" should set a CSS class on the inline-comment-box.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 25 2015, 5:51 PM
chad accepted this revision.Mar 25 2015, 5:53 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 25 2015, 5:53 PM
Closed by commit rP1fd163d0976c: Mostly provide CSS for "done" states (authored by epriestley, committed by epriestley). · Explain WhyMar 25 2015, 5:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
28 lines
src/
infrastructure/
diff/
view/
19 lines
webroot/
rsrc/
css/
application/
differential/
8 lines
js/
application/
differential/
9 lines

Diff 29229

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
View Options

webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js

Loading...
Phabricator · Built by Phacility