Page MenuHomePhabricator
Differential D12128

Publish "done" inline comment checkbox state in Diffusion
ClosedPublic
Actions

Authored by epriestley on Mar 22 2015, 1:03 PM.
Tags
None
Referenced Files
F14372209: D12128.id29154.diff
Fri, Dec 20, 7:39 PM
Unknown Object (File)
Fri, Dec 13, 9:36 AM
Unknown Object (File)
Mon, Dec 9, 2:42 AM
Unknown Object (File)
Thu, Dec 5, 11:22 AM
Unknown Object (File)
Tue, Dec 3, 11:51 AM
Unknown Object (File)
Sun, Dec 1, 6:33 AM
Unknown Object (File)
Tue, Nov 26, 9:38 PM
Unknown Object (File)
Fri, Nov 22, 7:00 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T1460: Add "Done" link to an inline comment
Commits
Restricted Diffusion Commit
rPcbb5a297d57b: Publish "done" inline comment checkbox state in Diffusion
Summary

Ref T1460. See D12126. This is essentially the same change, but for Diffusion.

This is a bit copy/pastey. I'm going to make an effort to lift inline handling into the core before pushing this in, so hopefully that will clean things up a bit.

Test Plan

Submitted stuff in Diffusion and got checkmarks to publish.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29154.Mar 22 2015, 1:03 PM
epriestley retitled this revision from to Publish "done" inline comment checkbox state in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T1460: Add "Done" link to an inline comment.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 22 2015, 1:03 PM
btrahan accepted this revision.Mar 23 2015, 5:02 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/diffusion/controller/DiffusionInlineCommentController.php
73

nice

This revision is now accepted and ready to land.Mar 23 2015, 5:02 PM
Closed by commit rPcbb5a297d57b: Publish "done" inline comment checkbox state in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyMar 24 2015, 12:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
62 lines
storage/
41 lines
diffusion/
controller/
2 lines

Diff 29184

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditTransaction.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionInlineCommentController.php

Loading...
Phabricator · Built by Phacility