Hide footer on mobile app switcher
ClosedPublic
Actions

Authored by chad on Mar 23 2015, 4:51 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T7609: page footer overlaps menu buttons on mobile device

Commits

Restricted Diffusion Commit
rP5f7b7f24d60d: Hide footer on mobile app switcher

Summary

Fixes T7609. When we moved the sidenav background to z-index -1, the footer then reappeared. Make the hiding more specific in CSS.

Test Plan

test mobile layout of homepage, check footer still exists on all other pages.

Diff Detail

Repository

rP Phabricator

Branch

footer

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4953
Build 4971: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29176.Mar 23 2015, 4:51 PM

chad retitled this revision from to Hide footer on mobile app switcher.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T7609: page footer overlaps menu buttons on mobile device.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 23 2015, 4:51 PM

epriestley accepted this revision.Mar 23 2015, 4:55 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 23 2015, 4:55 PM

Closed by commit rP5f7b7f24d60d: Hide footer on mobile app switcher (authored by chad, committed by chad). · Explain WhyMar 23 2015, 4:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

application/

base/

standard-page-view.css

4 lines

Diff 29176

View Options

resources/celerity/map.php