Clear floats around conpherence-edited transactions
ClosedPublic
Actions

Authored by chad on Mar 23 2015, 3:57 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T7647: Conpherence chat pane layout broken for first message

Commits

Restricted Diffusion Commit
rPc4d2fb087ee8: Clear floats around conpherence-edited transactions

Summary

Fixes T7647. We float both the time and description here and want the fluidity.

Test Plan

Review a new Conpherence in FF, Safari, Chrome.

Diff Detail

Repository

rP Phabricator

Branch

conph-fff

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4952
Build 4970: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29166.Mar 23 2015, 3:57 PM

chad retitled this revision from to Clear floats around conpherence-edited transactions.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T7647: Conpherence chat pane layout broken for first message.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 23 2015, 3:57 PM

epriestley accepted this revision.Mar 23 2015, 4:08 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 23 2015, 4:08 PM

Closed by commit rPc4d2fb087ee8: Clear floats around conpherence-edited transactions (authored by chad, committed by chad). · Explain WhyMar 23 2015, 4:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

view/

ConpherenceTransactionView.php

2 lines

Diff 29166

View Options

src/applications/conpherence/view/ConpherenceTransactionView.php

Clear floats around conpherence-edited transactionsClosedPublicActions