Page MenuHomePhabricator

Fix matching of very short project hashtags ending in a digit
ClosedPublic

Authored by epriestley on Mar 21 2015, 11:38 AM.
Tags
None
Referenced Files
F14738093: D12123.diff
Sun, Jan 19, 11:31 AM
Unknown Object (File)
Fri, Jan 17, 12:47 PM
Unknown Object (File)
Dec 11 2024, 5:05 AM
Unknown Object (File)
Dec 10 2024, 10:49 AM
Unknown Object (File)
Dec 6 2024, 4:59 PM
Unknown Object (File)
Dec 2 2024, 10:29 AM
Unknown Object (File)
Nov 28 2024, 7:56 PM
Unknown Object (File)
Nov 27 2024, 11:04 PM
Subscribers

Details

Summary

Fixes T7625. The way the regexp worked, "unusual" terminal characters required at least one character as a prefix in order to match. Allow 0 instead, so #a1 matches.

Test Plan

Added and executed unit test.

Diff Detail

Repository
rP Phabricator
Branch
hash1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4937
Build 4955: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix matching of very short project hashtags ending in a digit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 23 2015, 3:45 PM
This revision was automatically updated to reflect the committed changes.