Page MenuHomePhabricator
Differential D12114

Conpherence - grey out username mentions if they aren't in the conpherence
ClosedPublic
Actions

Authored by btrahan on Mar 19 2015, 10:42 PM.
Tags
None
Referenced Files
F14398229: D12114.diff
Sun, Dec 22, 1:17 PM
Unknown Object (File)
Sun, Dec 15, 10:08 AM
Unknown Object (File)
Sun, Dec 8, 12:15 AM
Unknown Object (File)
Mon, Dec 2, 10:44 PM
Unknown Object (File)
Tue, Nov 26, 10:53 PM
Unknown Object (File)
Nov 22 2024, 12:59 AM
Unknown Object (File)
Nov 18 2024, 12:18 AM
Unknown Object (File)
Nov 15 2024, 12:06 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Maniphest Tasks
T7578: Render username mentions in Conpherence in a disabled style if the user can not see the thread
Commits
Restricted Diffusion Commit
rPdcaafd6159da: Conpherence - grey out username mentions if they aren't in the conpherence
Summary

Fixes T7578. This was pretty easy because conpherence funnels all transacton stuff through this spot

Test Plan

made a new room so only my user was a participant. wrote "@myself will work and @anotherguy will be greyed out" and so it was as expected

Diff Detail

Repository
rP Phabricator
Branch
T7578
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4927
Build 4945: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 29136.Mar 19 2015, 10:42 PM
btrahan added a task: T7578: Render username mentions in Conpherence in a disabled style if the user can not see the thread.
btrahan retitled this revision from to Conpherence - grey out username mentions if they aren't in the conpherence.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 19 2015, 10:42 PM
epriestley accepted this revision.Mar 20 2015, 12:00 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 20 2015, 12:00 AM
Closed by commit rPdcaafd6159da: Conpherence - grey out username mentions if they aren't in the conpherence (authored by btrahan, committed by btrahan). · Explain WhyMar 24 2015, 8:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
view/
3 lines

Diff 29136

View Options

src/applications/conpherence/view/ConpherenceTransactionView.php

Loading...
Phabricator · Built by Phacility