Page MenuHomePhabricator

Conpherence - tweak global upload + durable conpherence interaction
ClosedPublic

Authored by btrahan on Mar 12 2015, 10:37 PM.
Tags
None
Referenced Files
F14036104: D12058.id29023.diff
Sun, Nov 10, 8:33 AM
F14035768: D12058.diff
Sun, Nov 10, 7:30 AM
F14030399: D12058.diff
Sat, Nov 9, 3:16 AM
F13975089: D12058.id29023.diff
Fri, Oct 18, 8:41 AM
F13968050: D12058.id29024.diff
Wed, Oct 16, 6:12 PM
F13961364: D12058.id29025.diff
Tue, Oct 15, 4:42 AM
Unknown Object (File)
Oct 7 2024, 5:10 AM
Unknown Object (File)
Sep 26 2024, 10:12 AM
Subscribers

Details

Summary

Ref T7539. This stuff is pretty whack - the "dragEnter" and "dragLeave" fire over and over and over despite not moving the mouse sometimes from JX.Mask interaction, causing that neat flickering effect. Fix this mess by disabling pointer events for the mask.

Test Plan

dragged a file to the durable column textarea. it uploaded and inlined the Fxxx into the message. tried uploading a few times and it worked repeatedly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Conpherence - tweak global upload + durable conpherence interaction.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

dragEnter and dragLeave are probably firing because the mask is appearing, so the cursor is "entering" the mask, but it also "left" the document so we flip out and hide the mask again. Maybe.

This revision is now accepted and ready to land.Mar 12 2015, 10:51 PM

I mean, I agree because that's kind of what's going on from a dom perspective... However, didn't seem to work when I tried tracking the mask separately... like the old code is

if (contains(page, e.getTarget()) {
  // drag update as appropos
}

and I added

} else if (JX.Stratcom.hasSigil(e.getTarget(), 'jx-mask')) {
  // drag update as appropos
}

...but that didn't seem to work. I also couldn't get it to stop from rapid firing with no mouse movement in this case.

btrahan edited edge metadata.

...genius!

btrahan edited the test plan for this revision. (Show Details)
btrahan edited edge metadata.
This revision was automatically updated to reflect the committed changes.