Ref T7539. This stuff is pretty whack - the "dragEnter" and "dragLeave" fire over and over and over despite not moving the mouse sometimes from JX.Mask interaction, causing that neat flickering effect. Fix this mess by disabling pointer events for the mask.
Details
Details
- Reviewers
epriestley chad - Maniphest Tasks
- T7539: Dragging a file into Durable Column on /home/ triggers full upload
- Commits
- Restricted Diffusion Commit
rP4d3bb6eb3438: Conpherence - tweak global upload + durable conpherence interaction
dragged a file to the durable column textarea. it uploaded and inlined the Fxxx into the message. tried uploading a few times and it worked repeatedly.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- foo
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4863 Build 4881: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
dragEnter and dragLeave are probably firing because the mask is appearing, so the cursor is "entering" the mask, but it also "left" the document so we flip out and hide the mask again. Maybe.
Comment Actions
I mean, I agree because that's kind of what's going on from a dom perspective... However, didn't seem to work when I tried tracking the mask separately... like the old code is
if (contains(page, e.getTarget()) {
// drag update as appropos
}and I added
} else if (JX.Stratcom.hasSigil(e.getTarget(), 'jx-mask')) {
// drag update as appropos
}...but that didn't seem to work. I also couldn't get it to stop from rapid firing with no mouse movement in this case.