Page MenuHomePhabricator

Conpherence - fix "pop in" effect
ClosedPublic

Authored by btrahan on Mar 11 2015, 11:14 PM.
Tags
None
Referenced Files
F14024991: D12047.id28998.diff
Thu, Nov 7, 1:48 PM
F14002365: D12047.id28997.diff
Fri, Oct 25, 6:21 PM
F13993225: D12047.id28998.diff
Tue, Oct 22, 9:32 PM
F13982464: D12047.diff
Sat, Oct 19, 11:30 PM
Unknown Object (File)
Sep 21 2024, 5:47 PM
Unknown Object (File)
Sep 19 2024, 9:13 AM
Unknown Object (File)
Sep 19 2024, 9:10 AM
Unknown Object (File)
Sep 18 2024, 1:03 AM
Subscribers

Details

Summary

Ref T7014. This got broken in today's action. For whatever reason the only way I can get the CSS to show up correctly is to move the require statement to where it was before rP5ef99dba2afc9f9ed3ca77707366a78be15f4871. Otherwise, this feature massages the UI a bit to make sure the "loading" stuff is set correctly in this state.

Test Plan

toggled conpherence open and it looked good. reloaded and it looked good.

Diff Detail

Repository
rP Phabricator
Branch
fixpopin
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4848
Build 4864: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Conpherence - fix "pop in" effect.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 11 2015, 11:19 PM
This revision was automatically updated to reflect the committed changes.