Page MenuHomePhabricator

Make durable column sticky across requests
ClosedPublic

Authored by epriestley on Mar 10 2015, 11:22 PM.
Tags
None
Referenced Files
F14106444: D12038.diff
Wed, Nov 27, 5:48 AM
Unknown Object (File)
Sat, Nov 23, 5:09 PM
Unknown Object (File)
Fri, Nov 22, 11:29 PM
Unknown Object (File)
Tue, Nov 19, 6:45 AM
Unknown Object (File)
Thu, Nov 14, 7:59 PM
Unknown Object (File)
Mon, Nov 11, 6:22 AM
Unknown Object (File)
Thu, Nov 7, 2:38 AM
Unknown Object (File)
Oct 19 2024, 10:07 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP88b46063b431: Make durable column sticky across requests
Summary

When you open the column, keep it open on future requests.

Test Plan

Opened column, clicked to Conpherence (no column), clicked elsewhere (column again), reloaded page (column), closed column, clicked something (no column).

Diff Detail

Repository
rP Phabricator
Branch
qsand2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4834
Build 4850: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make durable column sticky across requests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

This sort-of-kind-of breaks things by initializing the column too quickly (I think), let me see if I can find a fix that doesn't create too much of a mess.

  • Reasonable fix for the initialization issue for the moment.
btrahan edited edge metadata.
btrahan added inline comments.
webroot/rsrc/js/application/conpherence/behavior-durable-column.js
64

remove

This revision is now accepted and ready to land.Mar 11 2015, 12:01 AM
webroot/rsrc/js/application/conpherence/behavior-durable-column.js
64

haha thanks

This revision was automatically updated to reflect the committed changes.