Differential D12035

Conpherence - more threadManager stuff and get scrolling working
ClosedPublic
Actions

Authored by btrahan on Mar 10 2015, 8:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 16, 4:52 AM

	Unknown Object (File)
	Wed, Dec 11, 7:28 AM

	Unknown Object (File)
	Tue, Dec 10, 1:53 PM

	Unknown Object (File)
	Thu, Dec 5, 1:50 AM

	Unknown Object (File)
	Wed, Nov 27, 9:57 AM

	Unknown Object (File)
	Sat, Nov 23, 6:23 AM

	Unknown Object (File)
	Fri, Nov 22, 1:20 PM

	Unknown Object (File)
	Nov 18 2024, 4:33 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T7014: Annouce Persistent Chat option in Conpherence

Commits

Restricted Diffusion Commit
rP10f1692b1bac: Conpherence - more threadManager stuff and get scrolling working

Summary

Ref T7014. The main conpherence view is kind of broken without this in subtle ways because of /conpherence/ versus /conpherence/x/ init'ing things differently; this fixes that. Moves more normal view conpherence logic into threadManager. Makes all the display code happen outside of threadManager, setting us up for some display manager later maybe.

Test Plan

sent messages, updated title, etc and the messages pane auto scrolled correctly!

Diff Detail

Repository

Branch

T7014_3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4831
Build 4847: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 28969.Mar 10 2015, 8:50 PM

btrahan added a task: T7014: Annouce Persistent Chat option in Conpherence.

btrahan retitled this revision from to Conpherence - more threadManager stuff and get scrolling working.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 10 2015, 8:50 PM

epriestley accepted this revision.Mar 10 2015, 8:53 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 10 2015, 8:53 PM

Closed by commit rP10f1692b1bac: Conpherence - more threadManager stuff and get scrolling working (authored by btrahan, committed by btrahan). · Explain WhyMar 10 2015, 8:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

52 lines

src/

applications/

conpherence/

controller/

ConpherenceUpdateController.php

5 lines

ConpherenceViewController.php

1 line

view/

ConpherenceDurableColumnView.php

3 lines

ConpherenceLayoutView.php

8 lines

webroot/

rsrc/

externals/

javelin/

lib/

9 lines

js/

application/

conpherence/

ConpherenceThreadManager.js

65 lines

behavior-durable-column.js

50 lines

behavior-menu.js

59 lines

Diff 28969

resources/celerity/map.php

Loading...

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...

src/applications/conpherence/controller/ConpherenceViewController.php

Loading...

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Loading...

src/applications/conpherence/view/ConpherenceLayoutView.php

Loading...

webroot/rsrc/externals/javelin/lib/Scrollbar.js

Loading...

webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js

Loading...

webroot/rsrc/js/application/conpherence/behavior-durable-column.js

Loading...

webroot/rsrc/js/application/conpherence/behavior-menu.js

Loading...