Page MenuHomePhabricator
Differential D12027

Extend TransactionCommentQuery for Differential
ClosedPublic
Actions

Authored by epriestley on Mar 9 2015, 7:43 PM.
Tags
None
Referenced Files
F14906734: D12027.diff
Sun, Feb 9, 11:12 PM
Unknown Object (File)
Sat, Feb 8, 7:00 AM
Unknown Object (File)
Sat, Feb 8, 2:58 AM
Unknown Object (File)
Sat, Feb 8, 2:58 AM
Unknown Object (File)
Sat, Feb 8, 2:58 AM
Unknown Object (File)
Thu, Jan 30, 9:41 PM
Unknown Object (File)
Thu, Jan 30, 7:58 PM
Unknown Object (File)
Thu, Jan 30, 1:35 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
T1460: Add "Done" link to an inline comment
Commits
Restricted Diffusion Commit
rP7427a6e648cf: Extend TransactionCommentQuery for Differential
Summary

Ref T2009. Ref T1460. Replace hard-coded garbage with a real Query-layer query.

Test Plan

Submitted inline comments in Differential.

Diff Detail

Repository
rP Phabricator
Branch
uni35
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4820
Build 4836: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28950.Mar 9 2015, 7:43 PM
epriestley retitled this revision from to Extend TransactionCommentQuery for Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T1460: Add "Done" link to an inline comment, T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 9 2015, 7:43 PM
btrahan accepted this revision.Mar 9 2015, 8:42 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2015, 8:42 PM
Closed by commit rP7427a6e648cf: Extend TransactionCommentQuery for Differential (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 9:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
differential/
query/
31 lines
36 lines
transactions/
query/
30 lines
infrastructure/
diff/
query/
53 lines

Diff 28950

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/query/DifferentialDiffInlineCommentQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialTransactionQuery.php

Loading...
View Options

src/applications/transactions/query/PhabricatorApplicationTransactionCommentQuery.php

Loading...
View Options

src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php

Loading...
Phabricator · Built by Phacility