Page MenuHomePhabricator
Differential D12024

Reduce code duplication in inline right/left side tracking
ClosedPublic
Actions

Authored by epriestley on Mar 9 2015, 5:02 PM.
Tags
None
Referenced Files
F14102178: D12024.diff
Tue, Nov 26, 6:05 PM
Unknown Object (File)
Sat, Nov 23, 10:28 PM
Unknown Object (File)
Sat, Nov 23, 8:47 PM
Unknown Object (File)
Fri, Nov 22, 3:44 AM
Unknown Object (File)
Mon, Nov 18, 9:32 AM
Unknown Object (File)
Thu, Nov 14, 2:44 AM
Unknown Object (File)
Sun, Nov 10, 3:22 AM
Unknown Object (File)
Tue, Nov 5, 6:49 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
Commits
Restricted Diffusion Commit
rPf1f2c5d01df1: Reduce code duplication in inline right/left side tracking
Summary

Ref T2009. These subclasses have a mixture of similar methods, move them all to the base class.

Test Plan

Created/edited/undo/submitted comments on the left and right sides of a diff.

Diff Detail

Repository
rP Phabricator
Branch
uni32
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4815
Build 4831: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28936.Mar 9 2015, 5:02 PM
epriestley retitled this revision from to Reduce code duplication in inline right/left side tracking.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 9 2015, 5:02 PM
btrahan accepted this revision.Mar 9 2015, 6:55 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2015, 6:55 PM
Closed by commit rPf1f2c5d01df1: Reduce code duplication in inline right/left side tracking (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 7:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28936

View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentUndoView.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

Loading...
Phabricator · Built by Phacility