Page MenuHomePhabricator
Differential D12021

Hide revision content if author has not signed required legal documents
ClosedPublic
Actions

Authored by epriestley on Mar 9 2015, 12:36 AM.
Tags
None
Referenced Files
F15527926: D12021.id.diff
Tue, Apr 22, 7:36 AM
F15527741: D12021.id28937.diff
Tue, Apr 22, 6:14 AM
F15526634: D12021.diff
Mon, Apr 21, 9:55 PM
F15517520: D12021.id28937.diff
Sat, Apr 19, 3:34 AM
F15510909: D12021.diff
Wed, Apr 16, 9:56 PM
F15461956: D12021.diff
Tue, Apr 1, 12:41 PM
F15457472: D12021.diff
Sun, Mar 30, 5:04 PM
F15382702: D12021.diff
Mar 14 2025, 1:59 PM
View All Files
Subscribers
epriestley
Tokens
"Grey Medal" token, awarded by btrahan.

Details

Reviewers
btrahan
Maniphest Tasks
T7446: When a revision requires a CLA, hide the text of the diff
Commits
Restricted Diffusion Commit
rPb7be4ccca187: Hide revision content if author has not signed required legal documents
Summary

Fixes T7446.

Test Plan

Screen_Shot_2015-03-08_at_5.33.12_PM.png (1×1 px, 214 KB)

Diff Detail

Repository
rP Phabricator
Branch
uni30
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4812
Build 4828: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28931.Mar 9 2015, 12:36 AM
epriestley retitled this revision from to Hide revision content if author has not signed required legal documents.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7446: When a revision requires a CLA, hide the text of the diff.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 9 2015, 12:36 AM
btrahan accepted this revision.Mar 9 2015, 5:16 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/differential/controller/DifferentialRevisionViewController.php
452

looks like $comment_view gets appended twice in this code path

This revision is now accepted and ready to land.Mar 9 2015, 5:16 PM
btrahan awarded a token.Mar 9 2015, 5:17 PM
epriestley added inline comments.Mar 9 2015, 5:20 PM
src/applications/differential/controller/DifferentialRevisionViewController.php
452

Whoops, good catch. I've been scrolling past double comments all weekend.

epriestley updated this revision to Diff 28937.Mar 9 2015, 5:20 PM
epriestley edited edge metadata.
  • One comment view is enough comment views.
Closed by commit rPb7be4ccca187: Hide revision content if author has not signed required legal documents (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 5:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
47 lines
docs/
user/
userguide/
4 lines

Diff 28931

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/docs/user/userguide/legalpad.diviner

Loading...
Phabricator · Built by Phacility