Page MenuHomePhabricator
Differential D12013

Use ChangesetListView in Phriction
ClosedPublic
Actions

Authored by epriestley on Mar 8 2015, 1:03 PM.
Tags
None
Referenced Files
F18849377: D12013.id28938.diff
Thu, Oct 30, 9:28 AM
F18845757: D12013.id28920.diff
Wed, Oct 29, 2:17 PM
F18828235: D12013.id.diff
Fri, Oct 24, 3:15 PM
F18820093: D12013.diff
Wed, Oct 22, 12:30 PM
F18784198: D12013.id.diff
Mon, Oct 13, 12:06 PM
F18784195: D12013.id28920.diff
Mon, Oct 13, 12:06 PM
F18784114: D12013.diff
Mon, Oct 13, 11:53 AM
F18736520: D12013.id28920.diff
Oct 1 2025, 6:18 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
Commits
Restricted Diffusion Commit
rP100760fb313e: Use ChangesetListView in Phriction
Summary

Ref T2009. Upgrade this from DetailView to ListView so we get "Highlight As", "View Unified", etc., and respect the unified diff prefernce.

Test Plan

Viewed diffs in Phriction.

Diff Detail

Repository
rP Phabricator
Branch
uni25
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4804
Build 4820: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28920.Mar 8 2015, 1:03 PM
epriestley retitled this revision from to Use ChangesetListView in Phriction.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 8 2015, 1:03 PM
btrahan accepted this revision.Mar 9 2015, 5:15 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2015, 5:15 PM
Closed by commit rP100760fb313e: Use ChangesetListView in Phriction (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 5:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
controller/
36 lines

Diff 28920

View Options

src/applications/phriction/controller/PhrictionDiffController.php

Loading...
Phabricator · Built by Phacility