Differential D12007

Fix scrollbar being cut off at end of gutter
ClosedPublic
Actions

Authored by epriestley on Mar 7 2015, 5:30 PM.

Tags

None

Referenced Files

	F14035843: D12007.diff
	Sun, Nov 10, 7:45 AM

	F13988083: D12007.id28906.diff
	Mon, Oct 21, 1:03 PM

	Unknown Object (File)
	Oct 8 2024, 8:53 PM

	Unknown Object (File)
	Oct 7 2024, 10:20 PM

	Unknown Object (File)
	Oct 7 2024, 10:19 PM

	Unknown Object (File)
	Oct 7 2024, 10:19 PM

	Unknown Object (File)
	Oct 7 2024, 10:09 PM

	Unknown Object (File)
	Oct 6 2024, 4:22 AM

Subscribers

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rPb8ed980d3dc5: Fix scrollbar being cut off at end of gutter

Summary

The "mlb" on the left nav creates a phantom bottom margin which gives the content measurable height but not scrollable height. Replace it with "plb" (padding) instead.

The 2px-spacer calculation was also not quite correct.

Test Plan

Viewed pages with navs; padding vs margin didn't seem to make any other differences.
Scrollbar now stops in the right place in Safari, Chrome, Firefox.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28906.Mar 7 2015, 5:30 PM

epriestley retitled this revision from to Fix scrollbar being cut off at end of gutter.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 7 2015, 5:30 PM

chad accepted this revision.Mar 7 2015, 5:38 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 7 2015, 5:38 PM

Closed by commit rPb8ed980d3dc5: Fix scrollbar being cut off at end of gutter (authored by epriestley, committed by epriestley). · Explain WhyMar 7 2015, 5:54 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T7083: Scrollbar ends seemingly underneath page, gets cut off.Mar 22 2015, 12:30 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

16 lines

src/

view/

layout/

AphrontSideNavFilterView.php

2 lines

webroot/

rsrc/

externals/

javelin/

lib/

9 lines

Diff 28910

resources/celerity/map.php

Loading...

src/view/layout/AphrontSideNavFilterView.php

Loading...

webroot/rsrc/externals/javelin/lib/Scrollbar.js

Loading...