Page MenuHomePhabricator
Differential D12005

Change setErrorView to setInfoView in PHUIObjectBoxView
ClosedPublic
Actions

Authored by chad on Mar 7 2015, 12:25 AM.
Tags
None
Referenced Files
F14126101: D12005.diff
Sat, Nov 30, 1:08 PM
Unknown Object (File)
Wed, Nov 27, 11:46 AM
Unknown Object (File)
Wed, Nov 27, 11:45 AM
Unknown Object (File)
Wed, Nov 27, 11:45 AM
Unknown Object (File)
Wed, Nov 27, 11:32 AM
Unknown Object (File)
Sun, Nov 10, 7:08 AM
Unknown Object (File)
Fri, Nov 8, 11:01 PM
Unknown Object (File)
Oct 31 2024, 7:16 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP076cc6ed7ef8: Change setErrorView to setInfoView in PHUIObjectBoxView
Summary

Renames the method in PHUIObjectBoxView to match the new PHUIInfoView class.

Test Plan

grepped codebase. Went to Calendar and tried a new status.

Diff Detail

Repository
rP Phabricator
Branch
set-error-view
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4793
Build 4809: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28901.Mar 7 2015, 12:25 AM
chad retitled this revision from to Change setErrorView to setInfoView in PHUIObjectBoxView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 7 2015, 12:25 AM
epriestley accepted this revision.Mar 7 2015, 12:40 AM
epriestley edited edge metadata.

This might also need corresponding changes in rSAAS.

This revision is now accepted and ready to land.Mar 7 2015, 12:40 AM
Closed by commit rP076cc6ed7ef8: Change setErrorView to setInfoView in PHUIObjectBoxView (authored by chad, committed by chad). · Explain WhyMar 7 2015, 1:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
controller/
2 lines
auth/
controller/
config/
2 lines
calendar/
controller/
2 lines
config/
controller/
2 lines
dashboard/
controller/
2 lines
differential/
controller/
2 lines
4 lines
view/
4 lines
diffusion/
controller/
4 lines
2 lines
legalpad/
query/
2 lines
maniphest/
controller/
2 lines
2 lines
people/
controller/
2 lines
phortune/
controller/
2 lines
view/
phui/
8 lines
calendar/
4 lines

Diff 28901

View Options

src/applications/almanac/controller/AlmanacController.php

Loading...
View Options

src/applications/auth/controller/config/PhabricatorAuthListController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarViewController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigEditController.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardManageController.php

Loading...
View Options

src/applications/differential/controller/DifferentialDiffViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/view/DifferentialAddCommentView.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionExternalController.php

Loading...
View Options

src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestReportController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleInviteSendController.php

Loading...
View Options

src/applications/phortune/controller/PhortuneCartViewController.php

Loading...
View Options

src/view/phui/PHUIObjectBoxView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
Phabricator · Built by Phacility