Ref T7014.
Details
Details
- Reviewers
epriestley chad - Maniphest Tasks
- T7014: Annouce Persistent Chat option in Conpherence
- Commits
- Restricted Diffusion Commit
rP9b9a8001faae: Conpherence - add ability to change title in the durable column
changed the conpherence title from the column. since i can't get scrolling to work, i inspect the dom to verify the title change transaction showed up properly
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T7014
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4790 Build 4806: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I feel like we should always have a title other than [No Title]. e.g., list of participants. I'll file a separate task.
| src/applications/conpherence/view/ConpherenceDurableColumnView.php | ||
|---|---|---|
| 209–220 | Per me thinking this interaction is weird, what if we just put this in the dropdown menu, like "Rename Thread"? Then we could grey it out if you don't have permission, it would be obvious/discoverable/standard/etc. That leaves us with different interactions for "full" vs "column" Conpherence, but maybe we could find somewhere similar to put it in the full view. In particular, it might make sense to lift "Add Participants" up to the top level so you don't have to switch panels to do it? i..e, eventually have the same settings menu in "full" conpherence? | |
| src/applications/conpherence/view/ConpherenceDurableColumnView.php | ||
|---|---|---|
| 209–220 | I'd +1 putting this in the menu. Mostly, I'd prefer clicking on the title explain Policy once we had public, project, personal Conpherences. | |
Comment Actions
For consistency, maybe we could fit that in a subheader? Not sure exactly how things will break out, but something like:
Phacility
[lock] Private Room
Plot to Usurp Bob's Throne
[people] Private Thread
Funny Memes (LOL!)
[globe] Public Room
I don't know if we're really going to have a strong separation between "rooms" and "threads", but throwing it in the header makes a lot of sense to me if we do.
Comment Actions
It's not information I think is needed to see all the time (it also might look pretty cluttered up there) In the mocks I just used the icon to hint the audience. If that information is needed, I'd probably look at having the audience re-iterated by the [Send] button.