Differential D11998

Remove duplicate inline row scaffold in 1up renderer
ClosedPublic
Actions

Authored by epriestley on Mar 6 2015, 1:53 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity

Commits

Restricted Diffusion Commit
rPac60b23ef9e2: Remove duplicate inline row scaffold in 1up renderer

Summary

Ref T2009. This can now be removed.

Test Plan

Added, edited and deleted an inline comment in 1up view.

Diff Detail

Repository

rP Phabricator

Branch

uni18

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4785
Build 4801: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28886.Mar 6 2015, 1:53 PM

epriestley retitled this revision from to Remove duplicate inline row scaffold in 1up renderer.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 6 2015, 1:53 PM

btrahan accepted this revision.Mar 6 2015, 10:58 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 6 2015, 10:58 PM

Closed by commit rPac60b23ef9e2: Remove duplicate inline row scaffold in 1up renderer (authored by epriestley, committed by epriestley). · Explain WhyMar 6 2015, 11:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetOneUpRenderer.php

12 lines

Diff 28886

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Remove duplicate inline row scaffold in 1up rendererClosedPublicActions