Page MenuHomePhabricator
Differential D11979

Merge behavior-show-more into behavior-populate
ClosedPublic
Actions

Authored by epriestley on Mar 5 2015, 4:12 PM.
Tags
None
Referenced Files
F15526065: D11979.diff
Mon, Apr 21, 6:56 PM
F15514994: D11979.id28865.diff
Fri, Apr 18, 7:13 AM
F15489269: D11979.id28831.diff
Fri, Apr 11, 7:27 AM
F15485498: D11979.id28865.diff
Thu, Apr 10, 12:09 AM
F15479059: D11979.id.diff
Tue, Apr 8, 5:06 AM
F15476340: D11979.diff
Mon, Apr 7, 5:40 AM
F15292851: D11979.id28831.diff
Mar 5 2025, 3:01 AM
Unknown Object (File)
Feb 24 2025, 12:15 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
Commits
Restricted Diffusion Commit
rPaa98d9e5f8ce: Merge behavior-show-more into behavior-populate
Summary

Ref T2009. It doesn't make sense to have these as separate behaviors. We require a ChangesetViewManager to track view parameter state.

Test Plan

Interacted with changesets in Phriction, Differential and Diffusion.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28831.Mar 5 2015, 4:12 PM
epriestley retitled this revision from to Merge behavior-show-more into behavior-populate.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 5 2015, 4:12 PM
btrahan accepted this revision.Mar 5 2015, 8:58 PM
btrahan mentioned this in D11978: Always run "behavior-populate" before "behavior-show-more".
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2015, 8:58 PM
Closed by commit rPaa98d9e5f8ce: Merge behavior-show-more into behavior-populate (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2015, 10:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
31 lines
1 line
src/
applications/
differential/
controller/
1 line
view/
1 line
phriction/
controller/
1 line
webroot/
rsrc/
js/
application/
differential/
14 lines

Diff 28865

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDiffController.php

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-populate.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-show-more.js

Loading...
Phabricator · Built by Phacility