Page MenuHomePhabricator
Differential D11979

Merge behavior-show-more into behavior-populate
ClosedPublic
Actions

Authored by epriestley on Mar 5 2015, 4:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 12:20 PM
Unknown Object (File)
Mon, Nov 25, 2:07 PM
Unknown Object (File)
Tue, Nov 19, 8:06 PM
Unknown Object (File)
Nov 15 2024, 4:48 PM
Unknown Object (File)
Nov 12 2024, 9:14 AM
Unknown Object (File)
Nov 8 2024, 3:58 AM
Unknown Object (File)
Nov 4 2024, 5:03 AM
Unknown Object (File)
Oct 26 2024, 7:35 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
Commits
Restricted Diffusion Commit
rPaa98d9e5f8ce: Merge behavior-show-more into behavior-populate
Summary

Ref T2009. It doesn't make sense to have these as separate behaviors. We require a ChangesetViewManager to track view parameter state.

Test Plan

Interacted with changesets in Phriction, Differential and Diffusion.

Diff Detail

Repository
rP Phabricator
Branch
uni8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4759
Build 4775: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28831.Mar 5 2015, 4:12 PM
epriestley retitled this revision from to Merge behavior-show-more into behavior-populate.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 5 2015, 4:12 PM
btrahan accepted this revision.Mar 5 2015, 8:58 PM
btrahan mentioned this in D11978: Always run "behavior-populate" before "behavior-show-more".
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2015, 8:58 PM
Closed by commit rPaa98d9e5f8ce: Merge behavior-show-more into behavior-populate (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2015, 10:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
31 lines
1 line
src/
applications/
differential/
controller/
1 line
view/
1 line
phriction/
controller/
1 line
webroot/
rsrc/
js/
application/
differential/
14 lines

Diff 28831

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDiffController.php

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-populate.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-show-more.js

Loading...
Phabricator · Built by Phacility