Page MenuHomePhabricator
Differential D11972

Add a preference for always using unified diffs
ClosedPublic
Actions

Authored by epriestley on Mar 5 2015, 1:27 AM.
Tags
None
Referenced Files
F15482410: D11972.id28858.diff
Wed, Apr 9, 5:15 AM
F15480905: D11972.id28823.diff
Tue, Apr 8, 5:14 PM
F15480640: D11972.id.diff
Tue, Apr 8, 3:27 PM
F15478754: D11972.diff
Tue, Apr 8, 2:35 AM
F15478415: D11972.diff
Mon, Apr 7, 11:08 PM
F15434283: D11972.diff
Tue, Mar 25, 2:53 AM
F15390725: D11972.id28823.diff
Sat, Mar 15, 6:29 AM
F15389111: D11972.id28858.diff
Sat, Mar 15, 4:54 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
Commits
Restricted Diffusion Commit
rP33d7034276a2: Add a preference for always using unified diffs
Summary

Ref T2009. These aren't good enough to actually use so I won't land this yet, but it makes testing changes a lot easier.

Test Plan
  • Swapped setting.
  • Loaded revisions.
  • Saw setting respected.

Diff Detail

Repository
rP Phabricator
Branch
uni1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4751
Build 4767: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28823.Mar 5 2015, 1:27 AM
epriestley retitled this revision from to Add a preference for always using unified diffs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 5 2015, 1:27 AM
btrahan accepted this revision.Mar 5 2015, 6:37 PM
btrahan edited edge metadata.

I bet this lands some day soon. :)

This revision is now accepted and ready to land.Mar 5 2015, 6:37 PM
Closed by commit rP33d7034276a2: Add a preference for always using unified diffs (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2015, 10:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
9 lines
view/
15 lines
5 lines
settings/
panel/
21 lines
storage/
1 line
webroot/
rsrc/
js/
application/
differential/
5 lines

Diff 28823

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetDetailView.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

src/applications/settings/panel/PhabricatorDiffPreferencesSettingsPanel.php

Loading...
View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...
View Options

webroot/rsrc/js/application/differential/ChangesetViewManager.js

Loading...
Phabricator · Built by Phacility