Page MenuHomePhabricator
Differential D11953

Forbid construction of dashboard panels on various Phortune objects
ClosedPublic
Actions

Authored by epriestley on Mar 3 2015, 10:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 1:12 AM
Unknown Object (File)
Thu, Jan 30, 2:26 PM
Unknown Object (File)
Sun, Jan 26, 9:31 AM
Unknown Object (File)
Fri, Jan 24, 12:41 AM
Unknown Object (File)
Tue, Jan 21, 11:14 AM
Unknown Object (File)
Thu, Jan 9, 2:02 PM
Unknown Object (File)
Thu, Jan 9, 5:13 AM
Unknown Object (File)
Sun, Jan 5, 12:31 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7102: Dashboards mishandle Phortune Charges
Commits
Restricted Diffusion Commit
rP6b65c578c734: Forbid construction of dashboard panels on various Phortune objects
Summary

Fixes T7102. These panels don't work, aren't meaningful, and don't seem very useful.

We could eventually support providing context to dashboards somehow ("merchant dashboard") but don't have much of an apparent need for this.

Test Plan
  • Tried to create cart/subscription/charge dashboard panels.
  • Unable to create new ones.
  • The ones from before the change show a relevant error now.

Diff Detail

Repository
rP Phabricator
Branch
panelquery
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4731
Build 4745: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28778.Mar 3 2015, 10:54 AM
epriestley retitled this revision from to Forbid construction of dashboard panels on various Phortune objects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7102: Dashboards mishandle Phortune Charges.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 3 2015, 10:54 AM
btrahan accepted this revision.Mar 3 2015, 3:28 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 3 2015, 3:28 PM
Closed by commit rP6b65c578c734: Forbid construction of dashboard panels on various Phortune objects (authored by epriestley, committed by epriestley). · Explain WhyMar 3 2015, 6:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
dashboard/
paneltype/
8 lines
phortune/
query/
5 lines
5 lines
5 lines

Diff 28778

View Options

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

Loading...
View Options

src/applications/phortune/query/PhortuneCartSearchEngine.php

Loading...
View Options

src/applications/phortune/query/PhortuneChargeSearchEngine.php

Loading...
View Options

src/applications/phortune/query/PhortuneSubscriptionSearchEngine.php

Loading...
Phabricator · Built by Phacility