Page MenuHomePhabricator
Differential D11933

Add fluid-view as an option for PHUIDocumentView
ClosedPublic
Actions

Authored by chad on Mar 2 2015, 5:29 PM.
Tags
None
Referenced Files
F15341117: D11933.diff
Sun, Mar 9, 6:39 PM
Unknown Object (File)
Sat, Mar 1, 2:13 AM
Unknown Object (File)
Feb 8 2025, 2:48 AM
Unknown Object (File)
Feb 8 2025, 2:48 AM
Unknown Object (File)
Feb 8 2025, 2:48 AM
Unknown Object (File)
Feb 8 2025, 2:47 AM
Unknown Object (File)
Jan 30 2025, 7:39 AM
Unknown Object (File)
Jan 27 2025, 9:41 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T7431: Redesign Welcome Screen for Admins
Commits
Restricted Diffusion Commit
rP2d50712aadc6: Add fluid-view as an option for PHUIDocumentView
Summary

Fixes some UIExample UI issues, adds a new full-width setting for DocumentView

Test Plan

Test UIExamples at desktop and mobile breakpoints

pasted_file (569×1 px, 257 KB)

Diff Detail

Repository
rP Phabricator
Branch
fluid-document-view
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4709
Build 4723: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28743.Mar 2 2015, 5:29 PM
chad retitled this revision from to Add fluid-view as an option for PHUIDocumentView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 2 2015, 5:29 PM
chad edited the test plan for this revision. (Show Details)Mar 2 2015, 5:30 PM
chad added a task: T7431: Redesign Welcome Screen for Admins.Mar 2 2015, 6:57 PM
epriestley accepted this revision.Mar 2 2015, 6:57 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2015, 6:57 PM
Closed by commit rP2d50712aadc6: Add fluid-view as an option for PHUIDocumentView (authored by chad, committed by chad). · Explain WhyMar 2 2015, 8:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
uiexample/
examples/
4 lines
view/
phui/
10 lines
webroot/
rsrc/
css/
phui/
5 lines

Diff 28743

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/uiexample/examples/PHUIDocumentExample.php

Loading...
View Options

src/view/phui/PHUIDocumentView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-document.css

Loading...
Phabricator · Built by Phacility