Differential D11926

Don't show "View Raw" for removed comments
ClosedPublic
Actions

Authored by epriestley on Mar 2 2015, 3:06 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7232: View Raw on removed comments makes 400 bad request

Commits

Restricted Diffusion Commit
rPc99d84793b3f: Don't show "View Raw" for removed comments

Summary

Fixes T7232.

Test Plan

Saw "View Raw" gone for removed comment, still present and functional for non-removed comment.

Diff Detail

Repository

rP Phabricator

Branch

rmcomment

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4702
Build 4716: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28729.Mar 2 2015, 3:06 PM

epriestley retitled this revision from to Don't show "View Raw" for removed comments.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T7232: View Raw on removed comments makes 400 bad request.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 2 2015, 3:06 PM

chad accepted this revision.Mar 2 2015, 3:07 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 2 2015, 3:07 PM

Closed by commit rPc99d84793b3f: Don't show "View Raw" for removed comments (authored by epriestley, committed by epriestley). · Explain WhyMar 2 2015, 3:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

view/

PhabricatorApplicationTransactionView.php

4 lines

Diff 28729

View Options

src/applications/transactions/view/PhabricatorApplicationTransactionView.php

Don't show "View Raw" for removed commentsClosedPublicActions