This still needs some fine tuning, but wanted to get opinions. Using it on a laptop feels pretty good. This also moves durable-column.css into its own file since it'll likely continue to grow. Minor CSS tweaks to the near perfect rendition of durable column from pixel based mockups.
Details
Details
- Reviewers
epriestley btrahan - Commits
- Restricted Diffusion Commit
rP4ccd653cc7e7: Shrink side-nav on home when durable column is open
Press \ on my laptop. Having issues with Chrome however, but FF and Safari work as expected.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- duribles
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4666 Build 4680: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| webroot/rsrc/css/application/base/standard-page-view.css | ||
|---|---|---|
| 234 | This doesn't trigger in Chrome, it's ... odd. If I toggle the rule on and off, it works. Assume to be a Chrome bug and need to find a work around. | |
Comment Actions
UI is fine with me.
It would be nice to land this so I can work on T7014 without having to e.g. merge in a CSS file re-factor. :(
Comment Actions
At first glance I don't like this very much, but we can muck with it later if I don't get used to it before we launch this.
Comment Actions
I'd probably prefer an iconNav homepage outright (as an option for layout) non-dependent of Conpherence. The sidenav to me is fairly useless and I'd prefer the space on home.
Comment Actions
Yeah -- the side nav is the most useful part of the homepage for me by a wide margin. I have plenty of space for the dashboard even on my laptop, so this feels like it's turning the useful part into an icon hunt and that I'm getting nothing in exchange.
Comment Actions
I removed the icon magic and made this "Conpherence" since I sort of assume it completely goes away when you uninstall Conpherence.