Page MenuHomePhabricator
Differential D11890

Conpherence - auto focus the textarea on thread select and after sending a message
ClosedPublic
Actions

Authored by btrahan on Feb 25 2015, 11:05 PM.
Tags
None
Referenced Files
F14347154: D11890.diff
Thu, Dec 19, 2:50 AM
Unknown Object (File)
Thu, Dec 5, 6:19 AM
Unknown Object (File)
Sun, Dec 1, 12:52 PM
Unknown Object (File)
Sun, Nov 24, 12:54 PM
Unknown Object (File)
Nov 12 2024, 10:05 PM
Unknown Object (File)
Oct 18 2024, 4:42 AM
Unknown Object (File)
Oct 17 2024, 11:00 AM
Unknown Object (File)
Oct 17 2024, 12:50 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7135: Pressing "Ctrl-Enter" in Conpherence does not refocus on text entry
Commits
Restricted Diffusion Commit
rP2d4d79d1718a: Conpherence - auto focus the textarea on thread select and after sending a…
Summary

Fixes T7135. Also does a bit of a javascript cleanup in that we had an event - "conpherence-selectthread" - which really didn't need to be an event.

Test Plan

selected various conpherences from the list and they loaded correctly, including putting the cursor at the end of the text as appropriate. send many messages rapid fire without ever taking my hands off the keyboard.

Diff Detail

Repository
rP Phabricator
Branch
T7135a
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4652
Build 4666: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 28646.Feb 25 2015, 11:05 PM
btrahan added a task: T7135: Pressing "Ctrl-Enter" in Conpherence does not refocus on text entry.
btrahan retitled this revision from to Conpherence - auto focus the textarea on thread select and after sending a message.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 25 2015, 11:05 PM
btrahan added inline comments.Feb 25 2015, 11:08 PM
webroot/rsrc/js/application/conpherence/behavior-pontificate.js
147

I couldn't get this to work in this flow without a setTimeout wrapper. the 100 was chosen arbitrarily.

epriestley accepted this revision.Feb 25 2015, 11:11 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 25 2015, 11:11 PM
Closed by commit rP2d4d79d1718a: Conpherence - auto focus the textarea on thread select and after sending a… (authored by btrahan, committed by btrahan). · Explain WhyFeb 25 2015, 11:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
44 lines
webroot/
rsrc/
js/
application/
conpherence/
53 lines
8 lines

Diff 28646

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-menu.js

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-pontificate.js

Loading...
Phabricator · Built by Phacility