Page MenuHomePhabricator

Emit exit event from daemon handle when daemon is not running
ClosedPublic

Authored by epriestley on Feb 23 2015, 7:31 PM.
Tags
None
Referenced Files
F13230094: D11866.id.diff
Mon, May 20, 8:44 PM
F13214585: D11866.id28591.diff
Fri, May 17, 11:37 AM
F13182737: D11866.id28582.diff
Fri, May 10, 1:58 AM
Unknown Object (File)
Tue, May 7, 7:30 AM
Unknown Object (File)
Fri, May 3, 10:24 PM
Unknown Object (File)
Fri, May 3, 6:38 AM
Unknown Object (File)
Thu, May 2, 6:44 PM
Unknown Object (File)
Thu, Apr 25, 6:43 PM
Subscribers

Details

Summary

Ref T7352. Currently, if you ^C a daemon while the subprocess is not running (e.g., wiating to restart after a failure) we just exit without actually emitting the EXIT event.

This can leave the daemon log hanging around in the database until it eventually expires.

Instead, make sure this event always gets emitted when a daemon responds to ^C.

Test Plan

With failing tasks in queue so that the taskmasters exit immediately, ran phd start and then phd stop a few times. Preivously, this would leave phantom daemons; now it cleans them up.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Emit exit event from daemon handle when daemon is not running.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Also make typechecking more liberal, since integers 0 and 1 are acceptable memory reserves.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 24 2015, 5:18 PM
This revision was automatically updated to reflect the committed changes.