Fix Maniphest Reports scrolling issues
ClosedPublic
Actions

Authored by chad on Feb 24 2015, 5:33 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

Commits

Summary

Fixes T7099, also picked some new colors. Raphael can bind the graph to a dom element, which resolved the scrolling issue.

Test Plan

Tested scrolling on my laptop, desktop. Seems resolved.

Repository

rP Phabricator

Branch

maniphest-reports

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4639
Build 4653: [Placeholder Plan] Wait for 30 Seconds

chad retitled this revision from to Fix Maniphest reports.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad retitled this revision from Fix Maniphest reports to Fix Maniphest Reports scrolling issues.Feb 24 2015, 5:34 PM

btrahan edited edge metadata.

btrahan added inline comments.

webroot/rsrc/css/application/maniphest/report.css
15–16	looks like we lost some CSS rules; just double checking that was intended
webroot/rsrc/js/application/maniphest/behavior-line-chart.js
16	this is a wacky constructor IMO - weird to see two parameters can instead be a single parameter of a different type - but hey we didn't write it!

This revision is now accepted and ready to land.Feb 24 2015, 5:36 PM

webroot/rsrc/css/application/maniphest/report.css
15–16	These are pretty well denoted by "Week of" that they don't also need a color.
webroot/rsrc/js/application/maniphest/behavior-line-chart.js
16	Yeah, I read the manual! http://raphaeljs.com/reference.html#Raphael