Paths

Table of Contentst

Differential D11871

Convert taskmasters to use an autoscale pool
ClosedPublic
Actions

Authored by epriestley on Feb 24 2015, 1:59 AM.

Tags

None

Referenced Files

	F15504104: D11871.id28621.diff
	Mon, Apr 14, 3:52 PM

	F15502105: D11871.id28592.diff
	Sun, Apr 13, 10:41 PM

	F15495366: D11871.id.diff
	Sun, Apr 13, 4:01 AM

	F15492340: D11871.diff
	Sat, Apr 12, 1:24 PM

	F15485731: D11871.id28621.diff
	Thu, Apr 10, 2:00 AM

	F15411822: D11871.diff
	Mar 19 2025, 9:55 AM

	F15387065: D11871.id.diff
	Mar 15 2025, 1:46 AM

	Unknown Object (File)
	Mar 3 2025, 7:00 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7352: Improve daemon scalability in the cluster

Commits

Restricted Diffusion Commit
rPaf303f458b9c: Convert taskmasters to use an autoscale pool

Summary

Ref T7352. This is pretty straightforward. I renamed phd.start-taskmasters to phd.taskmasters for clarity.

Test Plan

Ran phd start, phd start --autoscale-reserve 0.25, phd restart --autoscale-reserve 0.25, etc.
Examined PID file to see options were passed.
I'm defaulting this off (0 reserve) and making it a flag rather than an option because it's a very advanced feature which is probably not useful outside of instancing.

Diff Detail

Repository

Branch

daemon9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4629
Build 4643: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28592.Feb 24 2015, 1:59 AM

epriestley retitled this revision from to Convert taskmasters to use an autoscale pool.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7352: Improve daemon scalability in the cluster.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 24 2015, 1:59 AM

btrahan accepted this revision.Feb 24 2015, 5:33 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 24 2015, 5:33 PM

Closed by commit rPaf303f458b9c: Convert taskmasters to use an autoscale pool (authored by epriestley, committed by epriestley). · Explain WhyFeb 24 2015, 10:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorExtraConfigSetupCheck.php

3 lines

option/

PhabricatorPHDConfigOptions.php

10 lines

daemon/

management/

PhabricatorDaemonManagementRestartWorkflow.php

6 lines

PhabricatorDaemonManagementStartWorkflow.php

8 lines

PhabricatorDaemonManagementWorkflow.php

49 lines

docs/

user/

configuration/

managing_daemons.diviner

5 lines

infrastructure/

daemon/

workers/

PhabricatorTaskmasterDaemon.php

22 lines

Diff 28592

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Loading...

src/applications/config/option/PhabricatorPHDConfigOptions.php

Loading...

src/applications/daemon/management/PhabricatorDaemonManagementRestartWorkflow.php

Loading...

src/applications/daemon/management/PhabricatorDaemonManagementStartWorkflow.php

Loading...

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

Loading...

src/docs/user/configuration/managing_daemons.diviner

Loading...

src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php

Loading...