Page MenuHomePhabricator
Differential D11855

Pass overseer configuration over stdin
ClosedPublic
Actions

Authored by epriestley on Feb 22 2015, 4:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 10:23 AM
Unknown Object (File)
Mon, Dec 23, 10:23 AM
Unknown Object (File)
Mon, Dec 23, 10:23 AM
Unknown Object (File)
Mon, Dec 23, 7:58 AM
Unknown Object (File)
Sun, Dec 22, 10:47 AM
Unknown Object (File)
Mon, Dec 16, 8:19 PM
Unknown Object (File)
Tue, Dec 10, 7:12 AM
Unknown Object (File)
Wed, Dec 4, 11:21 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7352: Improve daemon scalability in the cluster
Commits
Restricted Diffusion Commit
rP09f3d0bb7ec0: Pass overseer configuration over stdin
Summary

Ref T7352. This changes phd to pass configuration to overseers over stdin. We still run one overseer per daemon.

The "status" stuff needs some cleanup, but it's mostly just UI/cosmetic.

Test Plan
  • Ran phd debug, phd launch, phd start, phd status, phd stop, etc.
  • Verified PID files write in a reasonable format.

Diff Detail

Repository
rP Phabricator
Branch
daemon3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/daemon/control/PhabricatorDaemonReference.php:30XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 4605
Build 4619: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28561.Feb 22 2015, 4:45 PM
epriestley retitled this revision from to Pass overseer configuration over stdin.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7352: Improve daemon scalability in the cluster.
Herald added a subscriber: epriestley. · View Herald TranscriptFeb 22 2015, 4:45 PM
btrahan accepted this revision.Feb 23 2015, 5:40 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 23 2015, 5:40 PM
Closed by commit rP09f3d0bb7ec0: Pass overseer configuration over stdin (authored by epriestley, committed by epriestley). · Explain WhyFeb 24 2015, 10:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
scripts/
daemon/
13 lines
src/
applications/
daemon/
management/
41 lines
infrastructure/
daemon/
control/
19 lines

Diff 28561

View Options

scripts/daemon/launch_daemon.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

Loading...
View Options

src/infrastructure/daemon/control/PhabricatorDaemonReference.php

Loading...
Phabricator · Built by Phacility