Page MenuHomePhabricator

Disable caching of remarkup previews
ClosedPublic

Authored by epriestley on Feb 20 2015, 2:47 PM.
Tags
None
Referenced Files
F13239235: D11832.id28520.diff
Wed, May 22, 1:16 AM
F13222975: D11832.id.diff
Sun, May 19, 4:10 AM
F13219994: D11832.id28520.diff
Sat, May 18, 10:34 PM
F13207785: D11832.id.diff
Thu, May 16, 4:07 AM
F13207529: D11832.id28555.diff
Thu, May 16, 12:48 AM
F13203604: D11832.diff
Tue, May 14, 11:55 PM
F13186071: D11832.diff
Sat, May 11, 3:24 AM
Unknown Object (File)
Tue, May 7, 6:10 AM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP59ae91a5ce84: Disable caching of remarkup previews
Summary

We currently cache previews, but the vast majority of previews are never rendered again (e.g., they're a preview of someone partway through typing a comment).

Especially when editing large documents (Legalpad, Phriction), this can bloat the markup cache with data that will never be read and won't get purged for 30 days.

In particular, most of the data on admin.phacility.com is currently 1,000 previews of legalpad documents as I made minor edits to them over the course of several hours.

This isn't a big concern, but it's a very easy fix.

Test Plan
  • Previewed a legalpad document, verified that cache rows were not written as I mashed the keyboard.
  • Saved the document, verified a new cache row was written.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Disable caching of remarkup previews.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 20 2015, 4:14 PM
This revision was automatically updated to reflect the committed changes.