Differential D11846

Make Remarkup Notes not have margin as first or last child
ClosedPublic
Actions

Authored by chad on Feb 21 2015, 5:21 AM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP511c61948666: Make Remarkup Notes not have margin as first or last child

Summary

When a NOTE is at the top or bottom of a document, there is extra unwanted space.

Test Plan

Write a NOTE as the top of a Phriction document

Diff Detail

Repository

rP Phabricator

Branch

remarkup-note-first

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4596
Build 4610: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28546.Feb 21 2015, 5:21 AM

chad retitled this revision from to Make Remarkup Notes not have margin as first or last child.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 21 2015, 5:21 AM

chad edited the test plan for this revision. (Show Details)Feb 21 2015, 5:21 AM

epriestley accepted this revision.Feb 21 2015, 10:32 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 21 2015, 10:32 AM

Closed by commit rP511c61948666: Make Remarkup Notes not have margin as first or last child (authored by chad, committed by chad). · Explain WhyFeb 21 2015, 2:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

core/

remarkup.css

6 lines

Diff 28546

View Options

resources/celerity/map.php