Page MenuHomePhabricator
Differential D11842

Remove AphrontMiniPanelView
ClosedPublic
Actions

Authored by chad on Feb 20 2015, 11:49 PM.
Tags
None
Referenced Files
F15469639: D11842.id28540.diff
Fri, Apr 4, 3:11 PM
F15455549: D11842.diff
Sun, Mar 30, 3:04 AM
F15423919: D11842.id28540.diff
Sat, Mar 22, 7:27 PM
F15418453: D11842.diff
Thu, Mar 20, 11:27 PM
Unknown Object (File)
Mar 2 2025, 4:05 AM
Unknown Object (File)
Mar 1 2025, 2:13 AM
Unknown Object (File)
Jan 24 2025, 12:05 AM
Unknown Object (File)
Jan 5 2025, 8:56 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP7c9e73b31d4a: Remove AphrontMiniPanelView
Summary

Swaps out AphrontMiniPanelView usage with PHUIErrorView. Only used on homepage.

Test Plan

Grepped for usage, only home. Revisit a new home, see modern componant.

pasted_file (233×549 px, 37 KB)

Diff Detail

Repository
rP Phabricator
Branch
mini-panel
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4590
Build 4604: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28539.Feb 20 2015, 11:49 PM
chad retitled this revision from to Remove AphrontMiniPanelView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 20 2015, 11:49 PM
chad edited the test plan for this revision. (Show Details)Feb 20 2015, 11:50 PM
epriestley accepted this revision.Feb 21 2015, 12:00 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 21 2015, 12:00 AM
Closed by commit rP7c9e73b31d4a: Remove AphrontMiniPanelView (authored by chad, committed by chad). · Explain WhyFeb 21 2015, 12:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
2 lines
applications/
home/
controller/
3 lines
view/
layout/
webroot/
rsrc/
css/
aphront/
13 lines

Diff 28539

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...
View Options

src/view/layout/AphrontMiniPanelView.php

Loading...
View Options

webroot/rsrc/css/aphront/panel-view.css

Loading...
Phabricator · Built by Phacility