Paths

Table of Contentst

Differential D11813

Projects - fix translation strings in watcher edge class
ClosedPublic
Actions

Authored by btrahan on Feb 18 2015, 11:38 PM.

Tags

None

Referenced Files

	F18275311: D11813.id28474.diff
	Fri, Aug 22, 6:57 PM

	F18108004: D11813.id28478.diff
	Mon, Aug 11, 4:18 AM

	F18103144: D11813.id28474.diff
	Sun, Aug 10, 2:10 AM

	F18096207: D11813.id28477.diff
	Fri, Aug 8, 5:24 AM

	F17904973: D11813.id28477.diff
	Tue, Jul 29, 11:45 AM

	F17870414: D11813.id28478.diff
	Mon, Jul 28, 1:54 PM

	F17867315: D11813.id.diff
	Mon, Jul 28, 5:58 AM

	F17862144: D11813.diff
	Sun, Jul 27, 11:35 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T7319: '1 watcher(s)' as well as 'a member' in project edit logs

Commits

Restricted Diffusion Commit
rPa77127ab63bf: Projects - fix translation strings in watcher edge class

Summary

Fixes T7319. These need a "%s" for the count where they had a "%d"

Test Plan

plan in D11812 is no longer a lie! (watcher added / removed strings render correctly)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28474.Feb 18 2015, 11:38 PM

btrahan added a task: T7319: '1 watcher(s)' as well as 'a member' in project edit logs.

btrahan retitled this revision from to Projects - fix translation strings in edge class.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 18 2015, 11:38 PM

btrahan retitled this revision from Projects - fix translation strings in edge class to Projects - fix translation strings in watcher edge class.Feb 18 2015, 11:38 PM

The %s is correct, so maybe the other ones should flip?

This is kind of unintuitive, but basically the rule is "%s" to render as "2,345,678" (i.e., with commas and periods) and "%d" to render as "2345678". So "You see %s things(s)", but "Task ID %d".

flip it

epriestley accepted this revision.Feb 18 2015, 11:44 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 18 2015, 11:44 PM

btrahan updated this object.Feb 18 2015, 11:44 PM

btrahan edited edge metadata.

Closed by commit rPa77127ab63bf: Projects - fix translation strings in watcher edge class (authored by btrahan, committed by btrahan). · Explain WhyFeb 18 2015, 11:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

6 lines

Diff 28478

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...