Page MenuHomePhabricator
Differential D11805

Modernize XHProf
ClosedPublic
Actions

Authored by chad on Feb 18 2015, 7:41 PM.
Tags
None
Referenced Files
F14493099: D11805.id.diff
Fri, Jan 3, 12:24 AM
Unknown Object (File)
Tue, Dec 31, 10:54 PM
Unknown Object (File)
Tue, Dec 24, 8:24 AM
Unknown Object (File)
Tue, Dec 24, 8:24 AM
Unknown Object (File)
Tue, Dec 24, 8:24 AM
Unknown Object (File)
Tue, Dec 24, 8:24 AM
Unknown Object (File)
Tue, Dec 24, 8:24 AM
Unknown Object (File)
Tue, Dec 24, 6:18 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP11f0c1a47d15: Modernize XHProf
Summary

Use modern components, pht

Test Plan

I have no data locally, expect @epriestley to commandeer

Diff Detail

Repository
rP Phabricator
Branch
xhprof
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4543
Build 4557: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28456.Feb 18 2015, 7:41 PM
chad retitled this revision from to Modernize XHProf.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a subscriber: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 18 2015, 7:41 PM
epriestley accepted this revision.Feb 18 2015, 7:42 PM
epriestley edited edge metadata.

Looks fine to me. I don't actually have XHProf installed right now either. :P

This revision is now accepted and ready to land.Feb 18 2015, 7:42 PM
chad updated this revision to Diff 28458.Feb 18 2015, 7:49 PM
chad edited edge metadata.
  • Crumbs
chad updated this revision to Diff 28459.Feb 18 2015, 7:50 PM
  • Crumb text
Closed by commit rP11f0c1a47d15: Modernize XHProf (authored by chad, committed by chad). · Explain WhyFeb 18 2015, 7:51 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Feb 18 2015, 7:51 PM

shipitquick
whatcouldgowrong
babyinsanitywolf

Revision Contents
Changeset List

Diff 28458

View Options

src/applications/xhprof/controller/PhabricatorXHProfProfileController.php

Loading...
View Options

src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php

Loading...
View Options

src/applications/xhprof/view/PhabricatorXHProfProfileSymbolView.php

Loading...
View Options

src/applications/xhprof/view/PhabricatorXHProfProfileTopLevelView.php

Loading...
Phabricator · Built by Phacility