Page MenuHomePhabricator
Differential D11800

Allow a different SSH host to be set in Diffusion
ClosedPublic
Actions

Authored by epriestley on Feb 18 2015, 4:20 PM.
Tags
None
Referenced Files
F14099932: D11800.id28443.diff
Tue, Nov 26, 12:59 PM
Unknown Object (File)
Sat, Nov 23, 1:07 AM
Unknown Object (File)
Fri, Nov 22, 7:25 PM
Unknown Object (File)
Fri, Nov 22, 12:04 AM
Unknown Object (File)
Mon, Nov 18, 7:24 AM
Unknown Object (File)
Thu, Nov 14, 3:32 AM
Unknown Object (File)
Sun, Nov 10, 2:29 PM
Unknown Object (File)
Sun, Nov 10, 8:06 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6941: Move private Phacility repos to Phacility
Commits
Restricted Diffusion Commit
rP02b174c2af04: Allow a different SSH host to be set in Diffusion
Summary

Ref T6941. In the cluster (and in other reasonable setups) we've separated SSH load balancers from HTTP load balancers.

In particular, ELBs will not let you load balance port 22, so this is likely a reasonable/common issue in larger clusters in AWS.

Allow users to specify an alternate host for SSH traffic.

Test Plan

Set host to someting different, saw it reflected in UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28442.Feb 18 2015, 4:20 PM
epriestley retitled this revision from to Allow a different SSH host to be set in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6941: Move private Phacility repos to Phacility.
Herald added a subscriber: epriestley. · View Herald TranscriptFeb 18 2015, 4:20 PM
epriestley updated this revision to Diff 28443.Feb 18 2015, 4:20 PM
  • Also lock these options.
scripts/ssh/ssh-exec.php
22

This isn't precisely related, but was helpful in debugging this stuff.

btrahan accepted this revision.Feb 18 2015, 6:32 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 18 2015, 6:32 PM
Closed by commit rP02b174c2af04: Allow a different SSH host to be set in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyFeb 18 2015, 6:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
scripts/
ssh/
1 line
src/
applications/
diffusion/
config/
11 lines
repository/
storage/
5 lines

Diff 28447

View Options

scripts/ssh/ssh-exec.php

Loading...
View Options

src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility