Page MenuHomePhabricator
Differential D11785

Legalpad - fix requires signature transaction from always being saved
ClosedPublic
Actions

Authored by btrahan on Feb 17 2015, 7:05 PM.
Tags
None
Referenced Files
F19796473: D11785.id28408.diff
Fri, Feb 27, 3:42 PM
F18873545: D11785.id.diff
Nov 5 2025, 10:17 AM
F18866480: D11785.diff
Nov 3 2025, 5:21 PM
F18846790: D11785.id28408.diff
Oct 29 2025, 9:08 PM
F18844853: D11785.diff
Oct 29 2025, 7:51 AM
F18756237: D11785.id.diff
Oct 5 2025, 10:21 AM
F18752727: D11785.diff
Oct 4 2025, 4:13 PM
F18336297: D11785.diff
Aug 25 2025, 10:57 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7295: Saving a Legalpad document without making changes generates a "not require signatures" transaction
Commits
Restricted Diffusion Commit
rP82f47f968989: Legalpad - fix requires signature transaction from always being saved
Summary

Fixes T7295. Humbling debugging experience but I got it.

Test Plan

saved a legalpad doc without edits over and over and saw no "requires signature" transaction. toggled "requires signature", saved, and saw the transaction.

Diff Detail

Repository
rP Phabricator
Branch
T7295
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4515
Build 4529: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 28406.Feb 17 2015, 7:05 PM
btrahan added a task: T7295: Saving a Legalpad document without making changes generates a "not require signatures" transaction.
btrahan retitled this revision from to Legalpad - fix requires signature transaction from always being saved.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 17 2015, 7:05 PM
epriestley accepted this revision.Feb 17 2015, 7:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 17 2015, 7:06 PM
Closed by commit rP82f47f968989: Legalpad - fix requires signature transaction from always being saved (authored by btrahan, committed by btrahan). · Explain WhyFeb 17 2015, 7:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
legalpad/
editor/
7 lines

Diff 28406

View Options

src/applications/legalpad/editor/LegalpadDocumentEditor.php

Loading...
Phabricator · Built by Phacility