Show exception title as page title for AphrontUsageException
ClosedPublic
Actions

Authored by epriestley on Feb 15 2015, 3:27 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7273: Fix page title for AphrontUsageException

Commits

Restricted Diffusion Commit
rP80e399def946: Show exception title as page title for AphrontUsageException

Summary

Fixes T7273. This shows a better title (like "No Such Instance") instead of a generic one ("Unhandled Exception") when the user hits an AphrontUsageException.

Test Plan

Visited a nonexistent instance, got a nice title.

Diff Detail

Repository

rP Phabricator

Branch

xtitle

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4500
Build 4514: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28379.Feb 15 2015, 3:27 PM

epriestley retitled this revision from to Show exception title as page title for AphrontUsageException.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T7273: Fix page title for AphrontUsageException.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 15 2015, 3:27 PM

chad accepted this revision.Feb 15 2015, 3:31 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 15 2015, 3:31 PM

Closed by commit rP80e399def946: Show exception title as page title for AphrontUsageException (authored by epriestley, committed by epriestley). · Explain WhyFeb 15 2015, 3:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

response/

AphrontUnhandledExceptionResponse.php

8 lines

Diff 28379

View Options

src/aphront/response/AphrontUnhandledExceptionResponse.php

Show exception title as page title for AphrontUsageExceptionClosedPublicActions