Page MenuHomePhabricator
Differential D11768

Correct `notification.pid` to `notification.pidfile`
ClosedPublic
Actions

Authored by eliaspro on Feb 14 2015, 7:31 PM.
Tags
None
Referenced Files
F13235458: D11768.diff
Tue, May 21, 5:25 AM
F13224024: D11768.id28376.diff
Sun, May 19, 5:57 AM
F13211855: D11768.id28374.diff
Fri, May 17, 6:09 AM
F13205835: D11768.diff
Wed, May 15, 2:30 AM
F13188698: D11768.diff
Sat, May 11, 5:25 AM
Unknown Object (File)
Tue, May 7, 9:07 AM
Unknown Object (File)
Fri, May 3, 8:47 AM
Unknown Object (File)
Fri, Apr 26, 9:42 PM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPa8cc1c05e528: Correct `notification.pid` to `notification.pidfile`
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

The correct conf variable is notification.pidfile, not notification.pid.
See also:

  • src/applications/config/option/PhabricatorNotificationConfigOptions.php:58
  • src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php:34
Test Plan

Grepped the whole source of Phabricator for occurences of notification.pid,
but all matches pointed to notification.pidfile instead.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4497
Build 4511: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

eliaspro updated this revision to Diff 28374.Feb 14 2015, 7:31 PM
eliaspro retitled this revision from to Correct `notification.pid` to `notification.pidfile`.
eliaspro updated this object.
eliaspro edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 14 2015, 7:31 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley accepted this revision.Feb 14 2015, 10:32 PM
epriestley added a reviewer: epriestley.

Thanks!

This revision is now accepted and ready to land.Feb 14 2015, 10:32 PM
Closed by commit rPa8cc1c05e528: Correct `notification.pid` to `notification.pidfile` (authored by eliaspro, committed by epriestley). · Explain WhyFeb 14 2015, 10:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
docs/
user/
configuration/
2 lines

Diff 28374

View Options

src/docs/user/configuration/notifications.diviner

Loading...
Phabricator · Built by Phacility