Page MenuHomePhabricator

OAuth - add concept of "trusted" clients that get auto redirects
ClosedPublic

Authored by btrahan on Feb 9 2015, 10:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 21, 9:03 PM
Unknown Object (File)
Sat, Sep 21, 9:02 PM
Unknown Object (File)
Sat, Sep 21, 9:02 PM
Unknown Object (File)
Sat, Sep 21, 8:58 PM
Unknown Object (File)
Wed, Sep 18, 10:30 PM
Unknown Object (File)
Wed, Sep 18, 8:01 PM
Unknown Object (File)
Wed, Sep 18, 2:25 PM
Unknown Object (File)
Mon, Sep 2, 6:46 AM
Subscribers

Details

Summary

Fixes T7153.

Test Plan

used bin/auth trust-oauth-client and bin/auth untrust-oauth-client to set the bit and verify error states.

registered via oauth with bin/auth trust-oauth-client set and I did not have the confirmation screen
registered via oauth with bin/auth untrust-oauth-client set and I did have the confirmation screen

Diff Detail

Repository
rP Phabricator
Branch
T7153_3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4411
Build 4424: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to OAuth - add concept of "trusted" clients that get auto redirects.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Code looks solid to me.

This revision is now accepted and ready to land.Feb 9 2015, 10:18 PM
btrahan edited edge metadata.
This revision was automatically updated to reflect the committed changes.